src/lazy/SkDiscardablePixelRef.cpp - Issue 830033003: change API contract: disallow zero-sized images or surfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lazy/SkDiscardablePixelRef.cpp

Issue 830033003: change API contract: disallow zero-sized images or surfaces (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lazy/SkDiscardablePixelRef.cpp

diff --git a/src/lazy/SkDiscardablePixelRef.cpp b/src/lazy/SkDiscardablePixelRef.cpp

index c4e3654d1a73da586b2a9f37113276ef97005876..84152ed188a4d32ec2c58f74289da55396b46bda 100644

--- a/src/lazy/SkDiscardablePixelRef.cpp

+++ b/src/lazy/SkDiscardablePixelRef.cpp

@@ -98,6 +98,7 @@ bool SkInstallDiscardablePixelRef(SkImageGenerator* generator, SkBitmap* dst,

SkAutoTDelete<SkImageGenerator> autoGenerator(generator);

if ((NULL == autoGenerator.get())

|| (!autoGenerator->getInfo(&info))

+ || info.isEmpty()

|| (!dst->setInfo(info))) {

return false;

}

« no previous file with comments | « src/image/SkSurface_Raster.cpp ('k') | tests/SurfaceTest.cpp » ('j') | no next file with comments »