Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: chrome/browser/chromeos/extensions/external_cache_unittest.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add histogram description. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/external_cache_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/external_cache_unittest.cc b/chrome/browser/chromeos/extensions/external_cache_unittest.cc
index 9bec7305a86e17de0992315b492f699eaa0a0e94..bdc9802e7fb0df9e44a265769abfb7cb4c26abc6 100644
--- a/chrome/browser/chromeos/extensions/external_cache_unittest.cc
+++ b/chrome/browser/chromeos/extensions/external_cache_unittest.cc
@@ -207,13 +207,9 @@ TEST_F(ExternalCacheTest, Basic) {
base::FilePath temp_dir(CreateTempDir());
base::FilePath temp_file2 = temp_dir.Append("b.crx");
CreateFile(temp_file2);
- external_cache.OnExtensionDownloadFinished(kTestExtensionId2,
- temp_file2,
- true,
- GURL(),
- "2",
- extensions::ExtensionDownloaderDelegate::PingResult(),
- std::set<int>());
+ external_cache.OnExtensionDownloadFinished(
+ kTestExtensionId2, temp_file2, std::string(), true, GURL(), "2",
+ extensions::ExtensionDownloaderDelegate::PingResult(), std::set<int>());
WaitForCompletion();
EXPECT_EQ(provided_prefs()->size(), 3ul);
@@ -236,13 +232,9 @@ TEST_F(ExternalCacheTest, Basic) {
// Update not from Webstore.
base::FilePath temp_file4 = temp_dir.Append("d.crx");
CreateFile(temp_file4);
- external_cache.OnExtensionDownloadFinished(kTestExtensionId4,
- temp_file4,
- true,
- GURL(),
- "4",
- extensions::ExtensionDownloaderDelegate::PingResult(),
- std::set<int>());
+ external_cache.OnExtensionDownloadFinished(
+ kTestExtensionId4, temp_file4, std::string(), true, GURL(), "4",
+ extensions::ExtensionDownloaderDelegate::PingResult(), std::set<int>());
WaitForCompletion();
EXPECT_EQ(provided_prefs()->size(), 4ul);

Powered by Google App Engine
This is Rietveld 408576698