Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_updater.h

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add histogram description. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_external_updater.h
diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_updater.h b/chrome/browser/chromeos/app_mode/kiosk_external_updater.h
index e24bd78f54692ec523f9f4f39e52ae689813c996..dc9382b0e2cf9503bdfbd34972d80280b31f9bcc 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_external_updater.h
+++ b/chrome/browser/chromeos/app_mode/kiosk_external_updater.h
@@ -45,9 +45,11 @@ class KioskExternalUpdater : public disks::DiskMountManager::Observer,
};
struct ExternalUpdate {
ExternalUpdate();
+ ~ExternalUpdate();
Dmitry Polukhin 2015/01/15 12:45:13 nit, if they are empty, we shouldn't need them at
ginkage 2015/01/15 15:20:15 I've tried. :) ../../chrome/browser/chromeos/app_
std::string app_name;
base::FilePath external_crx;
+ std::string package_hash;
ExternalUpdateStatus update_status;
base::string16 error;
};

Powered by Google App Engine
This is Rietveld 408576698