Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add histogram description. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc b/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc
index ed2754e6bc33db86f2f01ea72eea81f1747be8a9..ca968ec3d392a01a993c395046de96617184996b 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc
@@ -16,11 +16,13 @@ KioskExternalUpdateValidator::KioskExternalUpdateValidator(
const scoped_refptr<base::SequencedTaskRunner>& backend_task_runner,
const std::string& app_id,
const base::FilePath& crx_dir,
+ const std::string& crx_hash,
const base::FilePath& crx_unpack_dir,
const base::WeakPtr<KioskExternalUpdateValidatorDelegate>& delegate)
: backend_task_runner_(backend_task_runner),
app_id_(app_id),
crx_dir_(crx_dir),
+ crx_hash_(crx_hash),
crx_unpack_dir_(crx_unpack_dir),
delegate_(delegate) {
}
@@ -30,12 +32,10 @@ KioskExternalUpdateValidator::~KioskExternalUpdateValidator() {
void KioskExternalUpdateValidator::Start() {
scoped_refptr<extensions::SandboxedUnpacker> unpacker(
- new extensions::SandboxedUnpacker(crx_dir_,
- extensions::Manifest::EXTERNAL_PREF,
- extensions::Extension::NO_FLAGS,
- crx_unpack_dir_,
- backend_task_runner_.get(),
- this));
+ new extensions::SandboxedUnpacker(
+ crx_dir_, crx_hash_, extensions::Manifest::EXTERNAL_PREF,
+ extensions::Extension::NO_FLAGS, crx_unpack_dir_,
+ backend_task_runner_.get(), this));
if (!backend_task_runner_->PostTask(
FROM_HERE,
base::Bind(&extensions::SandboxedUnpacker::Start, unpacker.get()))) {

Powered by Google App Engine
This is Rietveld 408576698