Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3455)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add histogram description. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc b/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
index 8f58335a1d6754a6239eb7b2f3dab5e8ff9227f2..28e413c160b5748672932fd6478cb78cb2001312 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
@@ -93,6 +93,9 @@ bool ShouldUpdateForHigherVersion(const std::string& version_1,
KioskExternalUpdater::ExternalUpdate::ExternalUpdate() {
}
+KioskExternalUpdater::ExternalUpdate::~ExternalUpdate() {
+}
+
KioskExternalUpdater::KioskExternalUpdater(
const scoped_refptr<base::SequencedTaskRunner>& backend_task_runner,
const base::FilePath& crx_cache_dir,
@@ -325,11 +328,10 @@ void KioskExternalUpdater::ValidateExternalUpdates() {
++it) {
if (it->second.update_status == PENDING) {
scoped_refptr<KioskExternalUpdateValidator> crx_validator =
- new KioskExternalUpdateValidator(backend_task_runner_,
- it->first,
- it->second.external_crx,
- crx_unpack_dir_,
- weak_factory_.GetWeakPtr());
+ new KioskExternalUpdateValidator(
+ backend_task_runner_, it->first, it->second.external_crx,
+ it->second.package_hash, crx_unpack_dir_,
+ weak_factory_.GetWeakPtr());
crx_validator->Start();
break;
}

Powered by Google App Engine
This is Rietveld 408576698