Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart

Issue 82953002: Inline the fixed array constructor manually in the SSA builder. Also track whether a fixed array ev… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart (revision 30542)
+++ sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart (working copy)
@@ -141,7 +141,8 @@
bool enableLengthTracking = true;
bool continueAnalyzing = true;
-
+ bool checksGrowable = false;
kasperl 2013/11/25 08:16:44 Is this always !enableLengthTracking? Should you u
ngeoffray 2013/11/25 08:33:31 Yes, it is always !enableLengthTracking. I combine
+
static const int MAX_ANALYSIS_COUNT = 16;
final Setlet<Element> analyzedElements = new Setlet<Element>();
@@ -249,9 +250,11 @@
}
if (!doNotChangeLengthSelectorsSet.contains(selectorName)) {
enableLengthTracking = false;
+ checksGrowable = true;
}
if (selectorName == 'length' && selector.isSetter()) {
enableLengthTracking = false;
+ checksGrowable = true;
assignments.add(inferrer.types.nullType);
}
} else if (selector.isCall()

Powered by Google App Engine
This is Rietveld 408576698