Inline the fixed array constructor manually in the SSA builder. Also track whether a fixed array ev…

sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of type_graph_inferrer;
 
 /**
  * A set of selector names that [List] implements, that we know do not
  * change the element type of the list, or let the list escape to code
  * that might change the element type.
@@ skipping 123 matching lines @@
 
   // The set of [TypeInformation] where the traced container could
   // flow in, and operations done on them.
   final Setlet<TypeInformation> allUsers = new Setlet<TypeInformation>();
 
   // The list of found assignments to the container.
   final List<TypeInformation> assignments = <TypeInformation>[];
 
   bool enableLengthTracking = true;
   bool continueAnalyzing = true;
-
+  bool checksGrowable = false;

[kasperl, 2013/11/25 08:16:44]

Is this always !enableLengthTracking? Should you update this flag when bailing
out?

[ngeoffray, 2013/11/25 08:33:31]

Yes, it is always !enableLengthTracking. I combined both flags into a
'callsGrowableMethod' flag.

+  
   static const int MAX_ANALYSIS_COUNT = 16;
   final Setlet<Element> analyzedElements = new Setlet<Element>();
 
   ContainerTracerVisitor(this.container, inferrer)
       : this.inferrer = inferrer, this.compiler = inferrer.compiler;
 
   List<TypeInformation> run() {
     // Collect the [TypeInformation] where the container can flow in,
     // as well as the operations done on all these [TypeInformation]s.
     List<TypeInformation> workList = <TypeInformation>[];
@@ skipping 87 matching lines @@
           }
         } else if (selector.isIndexSet()) {
           assignments.add(info.arguments.positional[1]);
         } else if (!selector.isIndex()) {
           bailout('Used in a not-ok selector');
           return;
         }
       }
       if (!doNotChangeLengthSelectorsSet.contains(selectorName)) {
         enableLengthTracking = false;
+        checksGrowable = true;
       }
       if (selectorName == 'length' && selector.isSetter()) {
         enableLengthTracking = false;
+        checksGrowable = true;
         assignments.add(inferrer.types.nullType);
       }
     } else if (selector.isCall()
                && !info.targets.every((element) => element.isFunction())) {
       bailout('Passed to a closure');
       return;
     }
   }
 
   bool isClosure(Element element) {
     if (!element.isFunction()) return false;
     Element outermost = element.getOutermostEnclosingMemberOrTopLevel();
     return outermost.declaration != element.declaration;
   }
 
   visitElementTypeInformation(ElementTypeInformation info) {
     if (isClosure(info.element)) {
       bailout('Returned from a closure');
     }
   }
 }