Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 829473004: When ARIA button contains a link, label text is ignored (Closed)

Created:
5 years, 11 months ago by ramya.v
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

When ARIA button contains a link, label text is ignored BUG=230390 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
A LayoutTests/accessibility/link-inside-button-accessible-text.html View 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/accessibility/link-inside-button-accessible-text-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
PTAL! Thanks
5 years, 11 months ago (2015-01-06 10:17:36 UTC) #2
ramya.v
On 2015/01/06 10:17:36, ramya.v wrote: > PTAL! > > Thanks @dominic Could you please review ...
5 years, 11 months ago (2015-01-27 03:06:00 UTC) #3
dmazzoni
lgtm
5 years, 11 months ago (2015-01-27 06:41:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829473004/1
5 years, 11 months ago (2015-01-27 09:39:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 10:53:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189019

Powered by Google App Engine
This is Rietveld 408576698