Source/modules/accessibility/AXNodeObject.h - Issue 829473004: When ARIA button contains a link, label text is ignored

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.h

Issue 829473004: When ARIA button contains a link, label text is ignored (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/link-inside-button-accessible-text-expected.txt ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXNodeObject.h

diff --git a/Source/modules/accessibility/AXNodeObject.h b/Source/modules/accessibility/AXNodeObject.h

index b5ba42decf14a9a1411797b4d368ebd7afb21525..93b0113e2af3a5d1bacb80b5fd42720099e4234e 100644

--- a/Source/modules/accessibility/AXNodeObject.h

+++ b/Source/modules/accessibility/AXNodeObject.h

@@ -68,7 +68,7 @@ protected:

AccessibilityRole determineAriaRoleAttribute() const;

void elementsFromAttribute(WillBeHeapVector<RawPtrWillBeMember<Element> >& elements, const QualifiedName&) const;

bool hasContentEditableAttributeSet() const;

- bool isDescendantOfBarrenParent() const;

+ virtual bool isDescendantOfBarrenParent() const override;

// This returns true if it's focusable but it's not content editable and it's not a control or ARIA control.

bool isGenericFocusableElement() const;

HTMLLabelElement* labelForElement(Element*) const;