Safe HGraphBuilder::Add<> and New<>

Safe HGraphBuilder::Add<> and New<>

R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18033

[Dmitry Lomov (no reviews), 2013-11-22 15:05:01]

PTAL. Making Add<> and New<> safe as discussed.

https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h#newcode1754
src/hydrogen.h:1754: return I::cast(AddInstruction(instr));
I could probably just make AddInstruction generic instead of adding a typed
variant, but that requires pulling its implementation into header file. wdyt?

[Dmitry Lomov (no reviews), 2013-11-22 15:05:26]

PTAL. Making Add<> and New<> safe as discussed.

[danno, 2013-11-22 16:42:40]

I like this. LGTM.

https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h#newcode1754
src/hydrogen.h:1754: return I::cast(AddInstruction(instr));
On 2013/11/22 15:05:01, Dmitry Lomov (chromium) wrote:
> I could probably just make AddInstruction generic instead of adding a typed
> variant, but that requires pulling its implementation into header file. wdyt?

I think this is OK. We should keep headers as free of complexity as possible.

[Dmitry Lomov (no reviews), 2013-11-22 19:05:30]

Committed patchset #1 manually as r18033 (presubmit successful).