Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 82943005: Safe HGraphBuilder::Add<> and New<> (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | src/hydrogen.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 181
182 HValue* return_value = BuildCodeStub(); 182 HValue* return_value = BuildCodeStub();
183 183
184 // We might have extra expressions to pop from the stack in addition to the 184 // We might have extra expressions to pop from the stack in addition to the
185 // arguments above. 185 // arguments above.
186 HInstruction* stack_pop_count = stack_parameter_count; 186 HInstruction* stack_pop_count = stack_parameter_count;
187 if (descriptor_->function_mode_ == JS_FUNCTION_STUB_MODE) { 187 if (descriptor_->function_mode_ == JS_FUNCTION_STUB_MODE) {
188 if (!stack_parameter_count->IsConstant() && 188 if (!stack_parameter_count->IsConstant() &&
189 descriptor_->hint_stack_parameter_count_ < 0) { 189 descriptor_->hint_stack_parameter_count_ < 0) {
190 HInstruction* constant_one = graph()->GetConstant1(); 190 HInstruction* constant_one = graph()->GetConstant1();
191 stack_pop_count = Add<HAdd>(stack_parameter_count, constant_one); 191 stack_pop_count = AddUncasted<HAdd>(stack_parameter_count, constant_one);
192 stack_pop_count->ClearFlag(HValue::kCanOverflow); 192 stack_pop_count->ClearFlag(HValue::kCanOverflow);
193 // TODO(mvstanton): verify that stack_parameter_count+1 really fits in a 193 // TODO(mvstanton): verify that stack_parameter_count+1 really fits in a
194 // smi. 194 // smi.
195 } else { 195 } else {
196 int count = descriptor_->hint_stack_parameter_count_; 196 int count = descriptor_->hint_stack_parameter_count_;
197 stack_pop_count = Add<HConstant>(count); 197 stack_pop_count = Add<HConstant>(count);
198 } 198 }
199 } 199 }
200 200
201 if (current_block() != NULL) { 201 if (current_block() != NULL) {
(...skipping 1121 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 return BuildUncheckedDictionaryElementLoad(receiver, key); 1323 return BuildUncheckedDictionaryElementLoad(receiver, key);
1324 } 1324 }
1325 1325
1326 1326
1327 Handle<Code> KeyedLoadDictionaryElementStub::GenerateCode(Isolate* isolate) { 1327 Handle<Code> KeyedLoadDictionaryElementStub::GenerateCode(Isolate* isolate) {
1328 return DoGenerateCode(isolate, this); 1328 return DoGenerateCode(isolate, this);
1329 } 1329 }
1330 1330
1331 1331
1332 } } // namespace v8::internal 1332 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.h » ('j') | src/hydrogen.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698