runtime/vm/intermediate_language_x64.cc - Issue 829133006: VM: Small generated code size improvements on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 829133006: VM: Small generated code size improvements on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

===================================================================

--- runtime/vm/intermediate_language_x64.cc (revision 42687)

+++ runtime/vm/intermediate_language_x64.cc (working copy)

@@ -1274,11 +1274,11 @@

break;

case kTypedDataInt16ArrayCid:

case kTypedDataUint16ArrayCid:

- case kTypedDataInt32ArrayCid:

- case kTypedDataUint32ArrayCid:

// Writable register because the value must be untagged before storing.

locs->set_in(2, Location::WritableRegister());

break;

+ case kTypedDataInt32ArrayCid:

+ case kTypedDataUint32ArrayCid:

case kTypedDataInt64ArrayCid:

locs->set_in(2, Location::RequiresRegister());

break;

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | no next file » | no next file with comments »