Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 829133006: VM: Small generated code size improvements on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1256 matching lines...) Expand 10 before | Expand all | Expand 10 after
1267 case kTypedDataInt8ArrayCid: 1267 case kTypedDataInt8ArrayCid:
1268 case kTypedDataUint8ArrayCid: 1268 case kTypedDataUint8ArrayCid:
1269 case kTypedDataUint8ClampedArrayCid: 1269 case kTypedDataUint8ClampedArrayCid:
1270 case kOneByteStringCid: 1270 case kOneByteStringCid:
1271 // TODO(fschneider): Add location constraint for byte registers (RAX, 1271 // TODO(fschneider): Add location constraint for byte registers (RAX,
1272 // RBX, RCX, RDX) instead of using a fixed register. 1272 // RBX, RCX, RDX) instead of using a fixed register.
1273 locs->set_in(2, Location::FixedRegisterOrSmiConstant(value(), RAX)); 1273 locs->set_in(2, Location::FixedRegisterOrSmiConstant(value(), RAX));
1274 break; 1274 break;
1275 case kTypedDataInt16ArrayCid: 1275 case kTypedDataInt16ArrayCid:
1276 case kTypedDataUint16ArrayCid: 1276 case kTypedDataUint16ArrayCid:
1277 case kTypedDataInt32ArrayCid:
1278 case kTypedDataUint32ArrayCid:
1279 // Writable register because the value must be untagged before storing. 1277 // Writable register because the value must be untagged before storing.
1280 locs->set_in(2, Location::WritableRegister()); 1278 locs->set_in(2, Location::WritableRegister());
1281 break; 1279 break;
1280 case kTypedDataInt32ArrayCid:
1281 case kTypedDataUint32ArrayCid:
1282 case kTypedDataInt64ArrayCid: 1282 case kTypedDataInt64ArrayCid:
1283 locs->set_in(2, Location::RequiresRegister()); 1283 locs->set_in(2, Location::RequiresRegister());
1284 break; 1284 break;
1285 case kTypedDataFloat32ArrayCid: 1285 case kTypedDataFloat32ArrayCid:
1286 case kTypedDataFloat64ArrayCid: 1286 case kTypedDataFloat64ArrayCid:
1287 // TODO(srdjan): Support Float64 constants. 1287 // TODO(srdjan): Support Float64 constants.
1288 locs->set_in(2, Location::RequiresFpuRegister()); 1288 locs->set_in(2, Location::RequiresFpuRegister());
1289 break; 1289 break;
1290 case kTypedDataInt32x4ArrayCid: 1290 case kTypedDataInt32x4ArrayCid:
1291 case kTypedDataFloat64x2ArrayCid: 1291 case kTypedDataFloat64x2ArrayCid:
(...skipping 5110 matching lines...) Expand 10 before | Expand all | Expand 10 after
6402 __ movq(R10, Immediate(kInvalidObjectPointer)); 6402 __ movq(R10, Immediate(kInvalidObjectPointer));
6403 __ movq(RBX, Immediate(kInvalidObjectPointer)); 6403 __ movq(RBX, Immediate(kInvalidObjectPointer));
6404 #endif 6404 #endif
6405 } 6405 }
6406 6406
6407 } // namespace dart 6407 } // namespace dart
6408 6408
6409 #undef __ 6409 #undef __
6410 6410
6411 #endif // defined TARGET_ARCH_X64 6411 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698