Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 829133006: VM: Small generated code size improvements on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_patcher_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_x64.cc (revision 42687)
+++ runtime/vm/flow_graph_compiler_x64.cc (working copy)
@@ -1249,7 +1249,7 @@
&target_label,
RawPcDescriptors::kUnoptStaticCall,
locs);
- __ Drop(argument_count);
+ __ Drop(argument_count, RCX);
#if defined(DEBUG)
__ movq(RBX, Immediate(kInvalidObjectPointer));
__ movq(R10, Immediate(kInvalidObjectPointer));
@@ -1311,7 +1311,7 @@
target_label,
RawPcDescriptors::kIcCall,
locs);
- __ Drop(argument_count);
+ __ Drop(argument_count, RCX);
}
@@ -1328,7 +1328,7 @@
target_label,
RawPcDescriptors::kIcCall,
locs);
- __ Drop(argument_count);
+ __ Drop(argument_count, RCX);
#if defined(DEBUG)
__ movq(R10, Immediate(kInvalidObjectPointer));
#endif
@@ -1392,7 +1392,7 @@
Isolate::kNoDeoptId, token_pos);
RecordSafepoint(locs);
AddDeoptIndexAtCall(Isolate::ToDeoptAfter(deopt_id), token_pos);
- __ Drop(argument_count);
+ __ Drop(argument_count, RCX);
}
@@ -1413,7 +1413,7 @@
RawPcDescriptors::kOptStaticCall,
locs);
AddStaticCallTarget(function);
- __ Drop(argument_count);
+ __ Drop(argument_count, RCX);
}
@@ -1565,7 +1565,7 @@
locs);
const Function& function = *sorted[i].target;
AddStaticCallTarget(function);
- __ Drop(argument_count);
+ __ Drop(argument_count, RCX);
if (!is_last_check) {
__ jmp(&match_found);
}
« no previous file with comments | « runtime/vm/code_patcher_x64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698