Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 82913009: Revert 236417 "Makes FocusdController honor focus change if no p..." (Closed)

Created:
7 years ago by sky
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 236417 "Makes FocusdController honor focus change if no p..." > Makes FocusdController honor focus change if no previously active window > > With desktop aura when a Window is made active the focus restore code > kicks in and attempts to restore focus to the Window that had focus > prior to losing activation. FocusController ignores requests to change > focus if during the activation phase focus changed. Together this > means the window that initiated the focus and activation change does > not get focus. > > Fix is to allow the focus change through if there was previously no > active window. > > BUG=321042 > TEST=covered by test now > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/75933005 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
M trunk/src/ui/views/corewm/focus_controller.cc View 1 chunk +1 line, -9 lines 0 comments Download
M trunk/src/ui/views/corewm/focus_controller_unittest.cc View 4 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
7 years ago (2013-11-23 00:03:02 UTC) #1
sky
7 years ago (2013-11-23 00:03:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r236879.

Powered by Google App Engine
This is Rietveld 408576698