Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 75933005: Makes FocusdController honor focus change if no previously active window (Closed)

Created:
7 years, 1 month ago by sky
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Visibility:
Public.

Description

Makes FocusdController honor focus change if no previously active window With desktop aura when a Window is made active the focus restore code kicks in and attempts to restore focus to the Window that had focus prior to losing activation. FocusController ignores requests to change focus if during the activation phase focus changed. Together this means the window that initiated the focus and activation change does not get focus. Fix is to allow the focus change through if there was previously no active window. BUG=321042 TEST=covered by test now R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -1 line) Patch
M ui/views/corewm/focus_controller.cc View 1 chunk +9 lines, -1 line 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 4 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
7 years, 1 month ago (2013-11-19 22:36:04 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-11-19 23:05:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/75933005/1
7 years, 1 month ago (2013-11-19 23:48:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=226714
7 years, 1 month ago (2013-11-20 06:36:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/75933005/1
7 years, 1 month ago (2013-11-21 04:11:22 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 06:35:41 UTC) #6
Message was sent while issue was closed.
Change committed as 236417

Powered by Google App Engine
This is Rietveld 408576698