chrome/browser/plugins/plugin_info_message_filter.cc - Issue 829113004: Plugin Power Saver: Add back 'Click to play' option as 4th for plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_info_message_filter.cc

Issue 829113004: Plugin Power Saver: Add back 'Click to play' option as 4th for plugins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/host_content_settings_map_unittest.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_info_message_filter.cc

diff --git a/chrome/browser/plugins/plugin_info_message_filter.cc b/chrome/browser/plugins/plugin_info_message_filter.cc

index 065b2519c42894a0149589029597a794c19e482a..301d2952d6775db9bf316753e0088ff97b5387e7 100644

--- a/chrome/browser/plugins/plugin_info_message_filter.cc

+++ b/chrome/browser/plugins/plugin_info_message_filter.cc

@@ -418,8 +418,9 @@ void PluginInfoMessageFilter::Context::DecidePluginStatus(

if (plugin_setting == CONTENT_SETTING_DETECT_IMPORTANT_CONTENT) {

status->value =

ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent;

- } else if (plugin_setting == CONTENT_SETTING_BLOCK ||

- plugin_setting == CONTENT_SETTING_ASK) {

+ } else if (plugin_setting == CONTENT_SETTING_ASK) {

+ status->value = ChromeViewHostMsg_GetPluginInfo_Status::kClickToPlay;

+ } else if (plugin_setting == CONTENT_SETTING_BLOCK) {

status->value =

is_managed ? ChromeViewHostMsg_GetPluginInfo_Status::kBlockedByPolicy

: ChromeViewHostMsg_GetPluginInfo_Status::kBlocked;

@@ -548,6 +549,7 @@ void PluginInfoMessageFilter::Context::MaybeGrantAccess(

const ChromeViewHostMsg_GetPluginInfo_Status& status,

const base::FilePath& path) const {

if (status.value == ChromeViewHostMsg_GetPluginInfo_Status::kAllowed ||

+ status.value == ChromeViewHostMsg_GetPluginInfo_Status::kClickToPlay ||

status.value ==

ChromeViewHostMsg_GetPluginInfo_Status::kPlayImportantContent) {

ChromePluginServiceFilter::GetInstance()->AuthorizePlugin(