Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 828983003: Add type annotations to metadata_dispatcher. (Closed)

Created:
5 years, 11 months ago by yawano
Modified:
5 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type annotations to metadata_dispatcher. BUG=444510 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/d2d5361dca5e7afbd1d4faedb7103c8398d2319a Cr-Commit-Position: refs/heads/master@{#309891}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -28 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js View 1 10 chunks +51 lines, -17 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js View 1 chunk +9 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/mpeg_parser.js View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 11 months ago (2015-01-05 02:20:22 UTC) #2
fukino
Thanks! lgtm with nits. https://codereview.chromium.org/828983003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js File ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js (right): https://codereview.chromium.org/828983003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js#newcode133 ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js:133: * @param {ByteReader} br Byte ...
5 years, 11 months ago (2015-01-05 03:32:47 UTC) #3
yawano
Thank you for the review! https://codereview.chromium.org/828983003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js File ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js (right): https://codereview.chromium.org/828983003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js#newcode133 ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js:133: * @param {ByteReader} br ...
5 years, 11 months ago (2015-01-05 03:38:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828983003/20001
5 years, 11 months ago (2015-01-05 03:39:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-05 04:16:56 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 04:18:03 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d2d5361dca5e7afbd1d4faedb7103c8398d2319a
Cr-Commit-Position: refs/heads/master@{#309891}

Powered by Google App Engine
This is Rietveld 408576698