ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js - Issue 828983003: Add type annotations to metadata_dispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js

Issue 828983003: Add type annotations to metadata_dispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed nits. Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js ('k') | ui/file_manager/file_manager/foreground/js/metadata/mpeg_parser.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js

diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js

index b58f2172b0e5c8b038a354020a7fcf6f0d42a665..52355eefdd7c8263676ca4ce81082a3b378e1b4d 100644

--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js

+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js

@@ -72,7 +72,15 @@ MetadataParser.readFileBytes = function(file, begin, end, callback, onError) {

fileReader.readAsArrayBuffer(file.slice(begin, end));

};

-/* Base class for image metadata parsers */

+/**

+ * Base class for image metadata parsers.

+ * @param {MetadataDispatcher} parent Parent object.

+ * @param {string} type Image type.

+ * @param {RegExp} urlFilter RegExp to match URLs.

+ * @constructor

+ * @struct

+ * @extends {MetadataParser}

+ */

function ImageParser(parent, type, urlFilter) {

MetadataParser.apply(this, arguments);

this.mimeType = 'image/' + this.type;