Issue 82873002: Limit the number of syscalls made by the Eventhandler.

Issue 82873002: Limit the number of syscalls made by the Eventhandler. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
zra, Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Limit the number of syscalls made by the Eventhandler. We now let epoll use EPOLLONESHOT instead of manual unsubscribing, and only to handle timeouts when no IO events was received. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30566

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : Mac fix. #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -16 lines)			Patch
M	runtime/bin/eventhandler_android.cc	View	1	3 chunks	+5 lines, -5 lines	1 comment	Download
M	runtime/bin/eventhandler_linux.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	1 2	3 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! https://codereview.chromium.org/82873002/diff/1/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/82873002/diff/1/runtime/bin/eventhandler_linux.cc#newcode76 runtime/bin/eventhandler_linux.cc:76: if (sd->port() != 0 && event.events != 0) ...

7 years, 1 month ago (2013-11-22 07:38:56 UTC) #2

Anders Johnsen

PTAL https://codereview.chromium.org/82873002/diff/1/runtime/bin/eventhandler_linux.cc File runtime/bin/eventhandler_linux.cc (right): https://codereview.chromium.org/82873002/diff/1/runtime/bin/eventhandler_linux.cc#newcode76 runtime/bin/eventhandler_linux.cc:76: if (sd->port() != 0 && event.events != 0) ...

7 years, 1 month ago (2013-11-22 07:48:33 UTC) #3

Anders Johnsen

Committed patchset #3 manually as r30566 (presubmit successful).

7 years, 1 month ago (2013-11-22 08:24:48 UTC) #5

zra

7 years, 1 month ago (2013-11-22 22:30:57 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/82873002/diff/110001/runtime/bin/eventhandler...
File runtime/bin/eventhandler_android.cc (right):

https://codereview.chromium.org/82873002/diff/110001/runtime/bin/eventhandler...
runtime/bin/eventhandler_android.cc:79: event.events |= EPOLLONESHOT;
Is this used only in the standalone VM? It isn't breaking the Android Dartium
build, but since EPOLLONESHOT doesn't exit in the NDK, it is breaking the
Android standalone VM build. (Sorry the Android build isn't possible from
build.py, yet. We're working on it. In the meantime maybe it would be best to
add me to CL's with Android changes so I can try them out before they land.)

Expand Messages | Collapse Messages