Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 828463003: Fix gsutil execution on Windows. (Closed)

Created:
5 years, 11 months ago by dnj
Modified:
5 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Fix gsutil execution on Windows. 5498b95831de0711fda19f2aabac4645ffb6cc78 runs gsutil using 'os.execv', which, on Windows, apparently causes it to return before completion. Also add verbosity to '7z' failures on toolchain downloading. BUG=chromium:445425 TEST=bot - Ran on bot, this fix solves the problem that we were seeing. R=pgervais@chromium.org, sergeyberezin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293507

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M gsutil.py View 1 4 chunks +10 lines, -4 lines 0 comments Download
M win_toolchain/toolchain2013.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dnj
PTAL
5 years, 11 months ago (2014-12-29 19:43:36 UTC) #2
Sergey Berezin
lgtm
5 years, 11 months ago (2014-12-29 19:46:41 UTC) #3
pgervais
lgtm with one nit. Up to you to fix it or not. https://chromiumcodereview.appspot.com/828463003/diff/1/gsutil.py File gsutil.py ...
5 years, 11 months ago (2014-12-29 19:46:59 UTC) #4
dnj (Google)
https://chromiumcodereview.appspot.com/828463003/diff/1/gsutil.py File gsutil.py (right): https://chromiumcodereview.appspot.com/828463003/diff/1/gsutil.py#newcode133 gsutil.py:133: os.exit(e.code) On 2014/12/29 19:46:59, pgervais wrote: > Use return ...
5 years, 11 months ago (2014-12-29 19:48:45 UTC) #6
dnj
5 years, 11 months ago (2014-12-29 19:50:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 293507.

Powered by Google App Engine
This is Rietveld 408576698