Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: win_toolchain/toolchain2013.py

Issue 828463003: Fix gsutil execution on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gsutil.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: win_toolchain/toolchain2013.py
diff --git a/win_toolchain/toolchain2013.py b/win_toolchain/toolchain2013.py
index 3ca83b4a924029ecc11363f084c31fcf1e70f07d..35dc1fcb117d415e5e6875aaaa34c430b6892e18 100755
--- a/win_toolchain/toolchain2013.py
+++ b/win_toolchain/toolchain2013.py
@@ -150,7 +150,7 @@ def ExtractIso(iso_path):
# TODO(scottmg): Do this (and exe) manually with python code.
# Note that at the beginning of main() we set the working directory to 7z's
# location so that 7z can find its codec dll.
- RunOrDie('7z x "%s" -y "-o%s" >nul' % (iso_path, target_path))
+ RunOrDie('7z x "%s" -y "-o%s"' % (iso_path, target_path))
return target_path
@@ -431,7 +431,7 @@ def DoTreeMirror(target_dir, tree_sha1):
local_zip = DownloadUsingGsutil(tree_sha1 + '.zip')
sys.stdout.write('Extracting %s...\n' % local_zip)
sys.stdout.flush()
- RunOrDie('7z x "%s" -y "-o%s" >nul' % (local_zip, target_dir))
+ RunOrDie('7z x "%s" -y "-o%s"' % (local_zip, target_dir))
def main():
« no previous file with comments | « gsutil.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698