Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 828313002: [turbofan] Truncation of Bit/Word8/16 to Word32 is a no-op. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Truncation of Bit/Word8/16 to Word32 is a no-op. TEST=mjsunit/compiler/regress-445859 BUG=chromium:445859 LOG=y R=jarin@chromium.org Committed: https://crrev.com/fb2643c858c96a783fced0c730a6ff89ea60eda5 Cr-Commit-Position: refs/heads/master@{#25951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-445859.js View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-02 10:03:02 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-02 10:03:17 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-02 10:05:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828313002/1
5 years, 11 months ago (2015-01-02 10:14:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-02 10:39:06 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 10:39:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb2643c858c96a783fced0c730a6ff89ea60eda5
Cr-Commit-Position: refs/heads/master@{#25951}

Powered by Google App Engine
This is Rietveld 408576698