src/compiler/simplified-lowering.cc - Issue 828313002: [turbofan] Truncation of Bit/Word8/16 to Word32 is a no-op.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 828313002: [turbofan] Truncation of Bit/Word8/16 to Word32 is a no-op. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 89c6bce4937e7b698aa26bcde836c783b7a4d9d9..bb5761469d144acc64748ec3224e650f44dac5a5 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -181,7 +181,7 @@ class RepresentationSelector {

} else {

// In the change phase, insert a change before the use if necessary.

MachineTypeUnion output = GetInfo(input)->output;

- if ((output & kRepWord32) == 0) {

+ if ((output & (kRepBit | kRepWord8 | kRepWord16 | kRepWord32)) == 0) {

// Output representation doesn't match usage.

TRACE((" truncate-to-int32: #%d:%s(@%d #%d:%s) ", node->id(),

node->op()->mnemonic(), index, input->id(),

« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-445859.js » ('j') | no next file with comments »