LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html - Issue 828163002: Don't check for layout in a canvas if it it's already needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html

Issue 828163002: Don't check for layout in a canvas if it it's already needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html

diff --git a/LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html b/LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html

new file mode 100644

index 0000000000000000000000000000000000000000..92095f8f2f7de643c0b5a8b7dde25abfbf554226

--- /dev/null

+++ b/LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html

@@ -0,0 +1,22 @@

+<!doctype HTML>

+crbug.com/445285: Do not crash when an element becomes positioned.

+<div class="container">

+ <canvas id="canvas-padding"</canvas>

+</div>

+<pre id="layer-tree">

+<script>

+ if (window.testRunner)

+ testRunner.dumpAsText();

+ document.head.appendChild(document.createElement("style"));

+ var styleSheet0 = document.styleSheets[0];

+ var test0=document.getElementById("canvas-padding")

+ var test2=document.getElementById("layer-tree")

+ styleSheet0.insertRule('.container,.container,.container,.container{background-size:50; float:right; }',styleSheet0.cssRules.length);

dsinclair 2015/01/05 14:58:18 Do these need to be inserted, or can they be added

Julien - ping for review 2015/01/06 11:36:13 Also do we need the same selector repeated 4 times

+ document.execCommand("usecss", "false")

+ test2.appendChild(test0.cloneNode(true));

+ test2.style['position']='absolute ';

+ styleSheet0.insertRule('#canvas-image,#canvas-simple,#canvas-padding{display: table-cell;}',0);

+ styleSheet0.insertRule('.container,.container{display: table;}',0);

+ document.execCommand("JustifyRight", false)

+ document.body.style.zoom=0.5145357251167297

Julien - ping for review 2015/01/06 11:36:13 Let's add a comment about this line changing the s

+</script>