LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html - Issue 828163002: Don't check for layout in a canvas if it it's already needed

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/crash-when-element-becomes-positioned-and-doesnt-clear-floating-objects.html

Issue 828163002: Don't check for layout in a canvas if it it's already needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!doctype HTML>

	2 crbug.com/445285: Do not crash when an element becomes positioned.

	3 <div class="container">

	4 <canvas id="canvas-padding"</canvas>

	5 </div>

	6 <pre id="layer-tree">

	7 <script>

	8 if (window.testRunner)

	9 testRunner.dumpAsText();

	10 document.head.appendChild(document.createElement("style"));

	11 var styleSheet0 = document.styleSheets[0];

	12 var test0=document.getElementById("canvas-padding")

	13 var test2=document.getElementById("layer-tree")

	14 styleSheet0.insertRule('.container,.container,.container,.container{backgrou nd-size:50; float:right; }',styleSheet0.cssRules.length);
	dsinclair 2015/01/05 14:58:18 Do these need to be inserted, or can they be added Do these need to be inserted, or can they be added to a <style> tag? Julien - ping for review 2015/01/06 11:36:13 Also do we need the same selector repeated 4 times Show quoted text On 2015/01/05 at 14:58:18, dsinclair wrote: > Do these need to be inserted, or can they be added to a <style> tag? Also do we need the same selector repeated 4 times in the rule? (and resp. 3 and 2 times below too).
	15 document.execCommand("usecss", "false")

	16 test2.appendChild(test0.cloneNode(true));

	17 test2.style['position']='absolute ';

	18 styleSheet0.insertRule('#canvas-image,#canvas-simple,#canvas-padding{display : table-cell;}',0);

	19 styleSheet0.insertRule('.container,.container{display: table;}',0);

	20 document.execCommand("JustifyRight", false)

	21 document.body.style.zoom=0.5145357251167297
	Julien - ping for review 2015/01/06 11:36:13 Let's add a comment about this line changing the s Let's add a comment about this line changing the size of the canvas, thus causing the crash. Maybe we could measure the size of the canvas to be sure it's correct using check-layout.js? I usually prefer check-layout.js tests to vanilla crash test as it tests correctness along with not-crashing.
	22 </script>

OLD	NEW