Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/object_id_ring.cc

Issue 82793004: Add field and function view for libraries. Rough cut. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/standalone/vmservice/isolate_class_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_id_ring.cc
===================================================================
--- runtime/vm/object_id_ring.cc (revision 30547)
+++ runtime/vm/object_id_ring.cc (working copy)
@@ -86,7 +86,7 @@
int32_t ObjectIdRing::AllocateNewId(RawObject* raw_obj) {
- ASSERT(raw_obj->IsHeapObject());
+ // TODO(turnidge): Do not enter Smis into the ObjectIdRing.
Ivan Posva 2013/11/22 22:58:36 I would actually leave the ASSERT in the code, jus
int32_t id = NextSerial();
ASSERT(id != kInvalidId);
int32_t cursor = IndexOfId(id);
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/standalone/vmservice/isolate_class_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698