Add field and function view for libraries. Rough cut.

runtime/vm/object_id_ring.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/dart_api_state.h"
 #include "vm/object_id_ring.h"
 
 namespace dart {
 
@@ skipping 68 matching lines @@
   serial_num_++;
   if (serial_num_ >= max_serial_) {
     serial_num_ = 0;
     wrapped_ = true;
   }
   return r;
 }
 
 
 int32_t ObjectIdRing::AllocateNewId(RawObject* raw_obj) {
-  ASSERT(raw_obj->IsHeapObject());
+  // TODO(turnidge): Do not enter Smis into the ObjectIdRing.

[Ivan Posva, 2013/11/22 22:58:36]

I would actually leave the ASSERT in the code, just commented out so that we do
not forget to put it back again.

   int32_t id = NextSerial();
   ASSERT(id != kInvalidId);
   int32_t cursor = IndexOfId(id);
   ASSERT(cursor != kInvalidId);
   if (table_[cursor] != Object::null()) {
     // Free old handle.
     table_[cursor] = Object::null();
   }
   ASSERT(table_[cursor] == Object::null());
   table_[cursor] = raw_obj;
@@ skipping 58 matching lines @@
       const int32_t max_serial_num = max_serial_;
       const int32_t bottom = max_serial_num - (capacity_ - serial_num_);
       return id >= bottom && bottom < max_serial_num;
     }
   }
   ASSERT(wrapped_ == false);
   return IsValidContiguous(id);
 }
 
 }  // namespace dart