Removing --enable-carrier-switching command-line flag

Removing --enable-carrier-switching command-line flag

It is obsolete now, so can be removed

BUG=

Committed: https://crrev.com/12d997aa1c0e469df8e5fc4be247ef6c1b65f451
Cr-Commit-Position: refs/heads/master@{#325816}

[anujsharma, 2015-01-12 12:27:51]

anujk.sharma@samsung.com changed reviewers:
+ rkc@chromium.org

[anujsharma, 2015-01-12 12:27:52]

@Rahul,

Could you please take a look over this change.
I am sending this CL to you, as you have marked this flag as obsolete. So, if
you are happy with this CL, i will raise a bug and will get it reviewed by
respective owners.

Thanks!!

[anujsharma, 2015-01-14 12:25:09]

@Rahul,

Please take a look.

Thanks!!

[rkc, 2015-02-18 23:27:00]

lgtm

[anujsharma, 2015-02-19 05:35:38]

anujk.sharma@samsung.com changed reviewers:
+ sky@chromium.org

[anujsharma, 2015-02-19 05:35:38]

sky@chromium.org: Please review changes in chrome/browser/ui module

[sky, 2015-02-19 17:04:45]

I'm not familiar with this flag. Did you get the person who added this flag to
make sure it's ok to remove it?

[anujsharma, 2015-04-16 05:56:10]

On 2015/02/19 17:04:45, sky wrote:
> I'm not familiar with this flag. Did you get the person who added this flag to
> make sure it's ok to remove it?

@sky

Sorry for the late response!! I was out of station.

As per the spreadsheet
https://docs.google.com/spreadsheets/d/1XwGEpBidtPKS_xFzW8bfQ4kbuVe0OuPlpMsSd...
shared by peter.
The owner of this flag is marked as RahulChaturvedi (rkc@chromium.org). He
himself has marked that flag as obsolete.
And moreover, he has also reviewd this CL and already given LGTM.

So, could you please now give a thumbs up for this CL.

Thanks!!

[sky, 2015-04-16 15:51:00]

https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:247:
localized_strings->SetBoolean(kShowCarrierSelectKey, false);
Is this still needed?

[anujsharma, 2015-04-17 13:41:06]

Thanks sky for pointing this out!!

https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:247:
localized_strings->SetBoolean(kShowCarrierSelectKey, false);
On 2015/04/16 15:51:00, sky wrote:
> Is this still needed?

I thought of removing it. But since "kShowCarrierSelectKey" was added stevenjb
as a part of https://codereview.chromium.org/673313003/ to for initialize the
"localized" dictionary values.

So, thatswhy i have not removed that key.
I will also check with stevenjb, if i can remove this key since i couldn't find
where it is used.

[anujsharma, 2015-04-17 13:41:37]

anujk.sharma@samsung.com changed reviewers:
+ stevenjb@chromium.org

[anujsharma, 2015-04-17 13:42:15]

@stevenjb:

PTAL

[stevenjb, 2015-04-17 16:31:58]

Hooray! lgtm as-is with follow-up as mentioned. This will actually trigger a
fair bit of JS and HTML removal, so I am happy to do that work.

https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:247:
localized_strings->SetBoolean(kShowCarrierSelectKey, false);
On 2015/04/17 13:41:05, anujsharma wrote:
> On 2015/04/16 15:51:00, sky wrote:
> > Is this still needed?
> 
> I thought of removing it. But since "kShowCarrierSelectKey" was added stevenjb
> as a part of https://codereview.chromium.org/673313003/ to for initialize the
> "localized" dictionary values.
> 
> So, thatswhy i have not removed that key.
> I will also check with stevenjb, if i can remove this key since i couldn't
find
> where it is used.

Please remove this here and from the JS, or add a TODO, assign the associated
issue to me after this CL, and I will remove it.

[anujsharma, 2015-04-20 05:12:47]

The CQ bit was checked by anujk.sharma@samsung.com

[anujsharma, 2015-04-20 05:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from rkc@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/827733003/#ps80001 (title:
"Fixed nits")

[anujsharma, 2015-04-20 05:13:45]

On 2015/04/17 16:31:58, stevenjb wrote:
> Hooray! lgtm as-is with follow-up as mentioned. This will actually trigger a
> fair bit of JS and HTML removal, so I am happy to do that work.
> 
>
https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
> File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
> (right):
> 
>
https://codereview.chromium.org/827733003/diff/40001/chrome/browser/ui/webui/...
> chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:247:
> localized_strings->SetBoolean(kShowCarrierSelectKey, false);
> On 2015/04/17 13:41:05, anujsharma wrote:
> > On 2015/04/16 15:51:00, sky wrote:
> > > Is this still needed?
> > 
> > I thought of removing it. But since "kShowCarrierSelectKey" was added
stevenjb
> > as a part of https://codereview.chromium.org/673313003/ to for initialize
the
> > "localized" dictionary values.
> > 
> > So, thatswhy i have not removed that key.
> > I will also check with stevenjb, if i can remove this key since i couldn't
> find
> > where it is used.
> 
> Please remove this here and from the JS, or add a TODO, assign the associated
> issue to me after this CL, and I will remove it.

Thanks stevenjb for lgtm.

I am sending one more CL to you regarding removal of kShowCarrierSelectKey.

[anujsharma, 2015-04-20 05:18:08]

The CQ bit was unchecked by anujk.sharma@samsung.com

[anujsharma, 2015-04-20 05:18:13]

The CQ bit was checked by anujk.sharma@samsung.com

[anujsharma, 2015-04-20 05:47:31]

The CQ bit was unchecked by anujk.sharma@samsung.com

[anujsharma, 2015-04-20 05:47:42]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2015-04-20 08:01:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/827733003/80001

[commit-bot: I haz the power, 2015-04-20 09:25:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-20 09:26:48]

Patchset 5 (id:??) landed as
https://crrev.com/12d997aa1c0e469df8e5fc4be247ef6c1b65f451
Cr-Commit-Position: refs/heads/master@{#325816}