More changes to make network settings better match extension API

More changes to make network settings better match extension API

This cleans up the remaining network properties code and sets
up the JS to use getManagedProperties().

It also breaks up 'networkCommand' into separate methods and documents which C++ methods called from JS need to be replaced with networkingPrivate calls or eliminated.

BUG=279351
Committed: https://crrev.com/2ab60d98289be5804e38ea8fdebcf78740fca095
Cr-Commit-Position: refs/heads/master@{#301949}

[stevenjb, 2014-10-24 22:54:57]

stevenjb@chromium.org changed reviewers:
+ pneubeck@chromium.org, tbarzic@chromium.org

[pneubeck (no reviews), 2014-10-27 16:37:20]

lgtm
in the light of missing automated tests, please make sure that this is indeed
working with a manual test (not necessarily by yourself)

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/network_list.js (right):

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/network_list.js:709:
showDetailsCallback,
showDetails.bind(null, data.servicePath);

is IMO a bit clearer, because it also makes the 'this' argument explicit.

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(left):

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:898:
UpdateConnectionData(service_path);
I don't see how this is replaced in the new code.
Or is it not required anymore?

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:566: //
This is only ever called to provided properties for the details page, so
typo: provided -> provide

[stevenjb, 2014-10-27 17:32:33]

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/network_list.js (right):

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/network_list.js:709:
showDetailsCallback,
On 2014/10/27 16:37:19, pneubeck wrote:
> showDetails.bind(null, data.servicePath);
> 
> is IMO a bit clearer, because it also makes the 'this' argument explicit.

Done.

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(left):

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:898:
UpdateConnectionData(service_path);
On 2014/10/27 16:37:19, pneubeck wrote:
> I don't see how this is replaced in the new code.
> Or is it not required anymore?

Not required any more. If there are state changes, the observers will trigger.

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/673313003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:566: //
This is only ever called to provided properties for the details page, so
On 2014/10/27 16:37:20, pneubeck wrote:
> typo: provided -> provide

Done.

[tbarzic, 2014-10-27 19:21:59]

lgtm

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:638: //
Append Service Path for now.
nit: Append sounds a bit strange with a dictionary. What do you think about Set
or Add?

[stevenjb, 2014-10-27 19:42:42]

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:638: //
Append Service Path for now.
On 2014/10/27 19:21:59, tbarzic wrote:
> nit: Append sounds a bit strange with a dictionary. What do you think about
Set
> or Add?

Done.

[stevenjb, 2014-10-27 19:42:46]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-10-27 19:44:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673313003/60001

[commit-bot: I haz the power, 2014-10-27 19:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-27 19:49:29]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/74066)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tbarzic, 2014-10-27 20:01:19]

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:638: //
Append Service Path for now.
On 2014/10/27 19:42:42, stevenjb wrote:
> On 2014/10/27 19:21:59, tbarzic wrote:
> > nit: Append sounds a bit strange with a dictionary. What do you think about
> Set
> > or Add?
> 
> Done.

you have a few more of these in this method :)

[stevenjb, 2014-10-29 21:05:44]

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
(right):

https://codereview.chromium.org/673313003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc:638: //
Append Service Path for now.
On 2014/10/27 20:01:19, tbarzic wrote:
> On 2014/10/27 19:42:42, stevenjb wrote:
> > On 2014/10/27 19:21:59, tbarzic wrote:
> > > nit: Append sounds a bit strange with a dictionary. What do you think
about
> > Set
> > > or Add?
> > 
> > Done.
> 
> you have a few more of these in this method :)

Done.

[stevenjb, 2014-10-29 21:05:49]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-10-29 21:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/673313003/100001

[commit-bot: I haz the power, 2014-10-29 22:05:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-29 22:06:26]

Patchset 6 (id:??) landed as
https://crrev.com/2ab60d98289be5804e38ea8fdebcf78740fca095
Cr-Commit-Position: refs/heads/master@{#301949}