Source/platform/mediastream/MediaStreamCenter.cpp - Issue 827673002: Add MediaStream.active attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/mediastream/MediaStreamCenter.cpp

Issue 827673002: Add MediaStream.active attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add MediaStream.active attribute Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/mediastream/MediaStreamCenter.cpp

diff --git a/Source/platform/mediastream/MediaStreamCenter.cpp b/Source/platform/mediastream/MediaStreamCenter.cpp

index d5bc111c945dc72fdefbd3b827a79a25cf179257..1479c2a9f09775189399ef26d9735dbcf7ac3bca 100644

--- a/Source/platform/mediastream/MediaStreamCenter.cpp

+++ b/Source/platform/mediastream/MediaStreamCenter.cpp

@@ -141,7 +141,7 @@ void MediaStreamCenter::stopLocalMediaStream(const WebMediaStream& webStream)

if (client)

client->streamEnded();

else

- stream->setEnded();

+ stream->setActive(false);

perkj_chrome 2015/01/13 08:24:31 Shouldn't you keep setEnded here? MediaStream.Stop

jiajia.qin 2015/01/13 08:52:45 Agree. I will leave this unchanged.

}

} // namespace blink