Source/platform/mediastream/MediaStreamCenter.cpp - Issue 827673002: Add MediaStream.active attribute

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/mediastream/MediaStreamCenter.cpp

Issue 827673002: Add MediaStream.active attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add MediaStream.active attribute Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Ericsson AB. All rights reserved.	2 * Copyright (C) 2011 Ericsson AB. All rights reserved.

3 * Copyright (C) 2012 Google Inc. All rights reserved.	3 * Copyright (C) 2012 Google Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 *	8 *

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 123 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
134 return nullptr;	134 return nullptr;

135 }	135 }

136	136

137 void MediaStreamCenter::stopLocalMediaStream(const WebMediaStream& webStream)	137 void MediaStreamCenter::stopLocalMediaStream(const WebMediaStream& webStream)

138 {	138 {

139 MediaStreamDescriptor* stream = webStream;	139 MediaStreamDescriptor* stream = webStream;

140 MediaStreamDescriptorClient* client = stream->client();	140 MediaStreamDescriptorClient* client = stream->client();

141 if (client)	141 if (client)

142 client->streamEnded();	142 client->streamEnded();

143 else	143 else

144 stream->setEnded();	144 stream->setActive(false);
	perkj_chrome 2015/01/13 08:24:31 Shouldn't you keep setEnded here? MediaStream.Stop Shouldn't you keep setEnded here? MediaStream.Stop is also deprecated but why not leave this unchanged. Alternatively, remove MediaStreamDescriptor.setEnded all together and just let MediaStream.ended mirror MediaStream.active. jiajia.qin 2015/01/13 08:52:45 Agree. I will leave this unchanged. Show quoted text On 2015/01/13 08:24:31, perkj wrote: > Shouldn't you keep setEnded here? MediaStream.Stop is also deprecated but why > not leave this unchanged. Agree. I will leave this unchanged. Show quoted text > Alternatively, remove MediaStreamDescriptor.setEnded all together and just let > MediaStream.ended mirror MediaStream.active. Does it mean that you think mediastream.ended is same with mediastream.inactive? Then, in any case(including the constructor function) where mediastream only contains empty or ended tracks, we need to call setEnded too?
145 }	145 }

146	146

147 } // namespace blink	147 } // namespace blink

OLD	NEW