make gn label unit tests pass again

make gn label unit tests pass again

Update the unit tests corresponding to this previous CL:
https://codereview.chromium.org/825013003

BUG=445454
TEST=gn_unittests --gtest_filter=Label*
R=brettw@chromium.org, tfarina@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/781d460cc35be4585de7cab07c65dd1474aa7022

[Mostyn Bramley-Moore, 2015-01-07 21:59:40]

mostynb@opera.com changed reviewers:
+ brettw@chromium.org, tfarina@chromium.org

[Mostyn Bramley-Moore, 2015-01-07 21:59:40]

@Thiago, Brett: here's the unittest followup to
https://codereview.chromium.org/825013003/ - sorry about the mixup (I thought
the gn unittests were being run).

[tfarina, 2015-01-07 22:23:21]

lgtm

I have patched this in and tried it. It fixed the Label.Resolve test. Thanks.

Could you add a TEST line to CL description? Something like:

TEST=gn_unittests --gtest_filter=Label*

[brettw, 2015-01-10 00:35:11]

lgtm

https://codereview.chromium.org/827643003/diff/20001/tools/gn/label_unittest.cc
File tools/gn/label_unittest.cc (right):

https://codereview.chromium.org/827643003/diff/20001/tools/gn/label_unittest....
tools/gn/label_unittest.cc:33: // Absolute paths are are allowed now.
I'd either delete this comment or just say "Absolute paths." Saying "allowed
now" only makes sense in the context of this code review, but not in the
resulting code.

[Mostyn Bramley-Moore, 2015-01-10 01:00:50]

https://codereview.chromium.org/827643003/diff/20001/tools/gn/label_unittest.cc
File tools/gn/label_unittest.cc (right):

https://codereview.chromium.org/827643003/diff/20001/tools/gn/label_unittest....
tools/gn/label_unittest.cc:33: // Absolute paths are are allowed now.
On 2015/01/10 00:35:11, brettw wrote:
> I'd either delete this comment or just say "Absolute paths." Saying "allowed
> now" only makes sense in the context of this code review, but not in the
> resulting code.

Done.

[Mostyn Bramley-Moore, 2015-01-10 01:00:58]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-01-10 01:01:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/827643003/40001

[commit-bot: I haz the power, 2015-01-10 01:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-10 01:08:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mostyn Bramley-Moore, 2015-01-10 01:20:40]

On 2015/01/10 01:08:07, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

This failure is due to some lines > 80 characters in the test case table that I
touched.  However most of the table is > 80 characters wide.  

Should I land the change without the commit queue, or reformat the table?

[brettw, 2015-01-11 02:47:03]

I think the test is much more clear with the long lines, so I land changes
manually.

[tfarina, 2015-01-13 02:26:02]

On 2015/01/11 02:47:03, brettw wrote:
> I think the test is much more clear with the long lines, so I land changes
> manually.

Mostyn, can I land this for you if you can't commit manually?

[Mostyn Bramley-Moore, 2015-01-13 06:59:09]

On 2015/01/13 02:26:02, tfarina wrote:
> Mostyn, can I land this for you if you can't commit manually?

If it's urgent, please do.  My commit access isn't working yet, I'm waiting for
someone to get back to me about that.

[commit-bot: I haz the power, 2015-01-13 15:00:27]

Patchset 3 (id:??) landed as
https://crrev.com/781d460cc35be4585de7cab07c65dd1474aa7022
Cr-Commit-Position: refs/heads/master@{#311270}

[tfarina, 2015-01-13 15:00:37]

Committed patchset #3 (id:40001) manually as
781d460cc35be4585de7cab07c65dd1474aa7022 (presubmit successful).