Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/gn/label_unittest.cc

Issue 827643003: make gn label unit tests pass again (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/label.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/label_unittest.cc
diff --git a/tools/gn/label_unittest.cc b/tools/gn/label_unittest.cc
index eb1e16c21cc78709ce58dee3533d1c05e1d0732b..02c658ae869a0b073faa8df5d3a74b79da6c213f 100644
--- a/tools/gn/label_unittest.cc
+++ b/tools/gn/label_unittest.cc
@@ -30,10 +30,9 @@ TEST(Label, Resolve) {
{ "//chrome/", "/:", false, "", "", "", "" },
{ "//chrome/", "blah", true, "//chrome/blah/", "blah", "//t/", "d" },
{ "//chrome/", "blah:bar", true, "//chrome/blah/", "bar", "//t/", "d" },
- // No single-leading slash.
- { "//chrome/", "/chrome:bar", false, "", "", "", "" },
- // No trailing slash.
- { "//chrome/", "/chrome/:bar", false, "", "", "", "" },
+ // Absolute paths.
+ { "//chrome/", "/chrome:bar", true , "/chrome/", "bar", "//t/", "d" },
+ { "//chrome/", "/chrome/:bar", true, "/chrome/", "bar", "//t/", "d" },
// Refers to root dir.
{ "//chrome/", "//:bar", true, "//", "bar", "//t/", "d" },
// Implicit directory
@@ -57,7 +56,7 @@ TEST(Label, Resolve) {
{ "//chrome/", "//chrome:bar(()", false, "", "", "", "" },
{ "//chrome/", "(t:b)", false, "", "", "", "" },
{ "//chrome/", ":bar(//t/b)", true, "//chrome/", "bar", "//t/b/", "b" },
- { "//chrome/", ":bar(/t/b)", false, "", "", "", "" },
+ { "//chrome/", ":bar(/t/b)", true, "//chrome/", "bar", "/t/b/", "b" },
{ "//chrome/", ":bar(t/b)", true, "//chrome/", "bar", "//chrome/t/b/", "b" },
};
« no previous file with comments | « tools/gn/label.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698