Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Side by Side Diff: chrome/browser/remoting/firewall_traversal_observer.cc

Issue 8275012: Remove RemoteAccessClientFirewallTraversal policy and code paths. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-rebase Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/remoting/firewall_traversal_observer.h"
6
7 #include "base/stringprintf.h"
8 #include "base/json/json_writer.h"
9 #include "base/values.h"
10 #include "chrome/browser/prefs/pref_service.h"
11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/common/chrome_notification_types.h"
13 #include "chrome/common/pref_names.h"
14 #include "content/browser/renderer_host/render_view_host.h"
15 #include "content/public/browser/notification_details.h"
16 #include "content/public/browser/notification_source.h"
17 #include "content/common/view_messages.h"
18 #include "ipc/ipc_message_macros.h"
19
20 FirewallTraversalObserver::FirewallTraversalObserver(
21 TabContents* tab_contents)
22 : TabContentsObserver(tab_contents) {
23 // Register for notifications about all interested prefs change.
24 Profile* profile =
25 Profile::FromBrowserContext(tab_contents->browser_context());
26 PrefService* prefs = profile->GetPrefs();
27 pref_change_registrar_.Init(prefs);
28 if (prefs) {
29 pref_change_registrar_.Add(prefs::kRemoteAccessClientFirewallTraversal,
30 this);
31 // kRemoteAccessHostFirewallTraversal intentionally not added because
32 // the host plugin is going to track it itself.
33 }
34 }
35
36 FirewallTraversalObserver::~FirewallTraversalObserver() {
37 // We don't want any notifications while we're running our destructor.
38 pref_change_registrar_.RemoveAll();
39 }
40
41 // static
42 void FirewallTraversalObserver::RegisterUserPrefs(PrefService* prefs) {
43 prefs->RegisterBooleanPref(prefs::kRemoteAccessClientFirewallTraversal,
44 true,
45 PrefService::UNSYNCABLE_PREF);
46 prefs->RegisterBooleanPref(prefs::kRemoteAccessHostFirewallTraversal,
47 true,
48 PrefService::UNSYNCABLE_PREF);
49 }
50
51 void FirewallTraversalObserver::Observe(
52 int type,
53 const content::NotificationSource& source,
54 const content::NotificationDetails& details) {
55 switch (type) {
56 case chrome::NOTIFICATION_PREF_CHANGED: {
57 std::string* pref_name_in = content::Details<std::string>(details).ptr();
58 Profile* profile =
59 Profile::FromBrowserContext(tab_contents()->browser_context());
60 DCHECK(content::Source<PrefService>(source).ptr() == profile->GetPrefs());
61 if (*pref_name_in == prefs::kRemoteAccessClientFirewallTraversal) {
62 UpdateFirewallTraversalState();
63 } else {
64 NOTREACHED() << "unexpected pref change notification" << *pref_name_in;
65 }
66 break;
67 }
68 default:
69 NOTREACHED();
70 }
71 }
72
73 void FirewallTraversalObserver::UpdateFirewallTraversalState() {
74 const char* pref_name = prefs::kRemoteAccessClientFirewallTraversal;
75 Profile* profile =
76 Profile::FromBrowserContext(tab_contents()->browser_context());
77 bool enabled = profile->GetPrefs()->GetBoolean(pref_name);
78
79 DictionaryValue value;
80 value.SetBoolean(pref_name, enabled);
81 std::string policy;
82 base::JSONWriter::Write(&value, false, &policy);
83 Send(new ViewMsg_UpdateRemoteAccessClientFirewallTraversal(routing_id(),
84 policy));
85 }
86
87 bool FirewallTraversalObserver::OnMessageReceived(const IPC::Message& msg) {
88 bool handled = true;
89 IPC_BEGIN_MESSAGE_MAP(FirewallTraversalObserver, msg)
90 IPC_MESSAGE_HANDLER(ViewHostMsg_RequestRemoteAccessClientFirewallTraversal,
91 UpdateFirewallTraversalState)
92
93 // Have the super handle all other messages.
94 IPC_MESSAGE_UNHANDLED(handled = false)
95 IPC_END_MESSAGE_MAP()
96
97 return handled;
98 }
OLDNEW
« no previous file with comments | « chrome/browser/remoting/firewall_traversal_observer.h ('k') | chrome/browser/remoting/firewall_traversal_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698