Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 827293003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/app_mode. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
achuithb
CC:
chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/app_mode. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=achuith@chromium.org Committed: https://crrev.com/6740e67a815510b2a563dec1d7c9de256ad6d3ee Cr-Commit-Position: refs/heads/master@{#311795}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -115 lines) Patch
M chrome/browser/chromeos/app_mode/app_launch_utils.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/app_mode/app_session_lifetime.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/app_mode/certificate_manager_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 5 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.h View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.h View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_diagnosis_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_diagnosis_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_external_updater.h View 2 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.h View 1 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/app_mode/startup_app_launcher.h View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 20:02:33 UTC) #1
achuithb
lgtm https://codereview.chromium.org/827293003/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/827293003/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode51 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:51: // LoginPerformer::Delegate overrides nit: colon here for consistency
5 years, 11 months ago (2015-01-15 23:56:26 UTC) #2
dcheng
https://codereview.chromium.org/827293003/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h File chrome/browser/chromeos/app_mode/kiosk_profile_loader.h (right): https://codereview.chromium.org/827293003/diff/1/chrome/browser/chromeos/app_mode/kiosk_profile_loader.h#newcode51 chrome/browser/chromeos/app_mode/kiosk_profile_loader.h:51: // LoginPerformer::Delegate overrides On 2015/01/15 23:56:25, achuithb wrote: > ...
5 years, 11 months ago (2015-01-16 00:02:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827293003/20001
5 years, 11 months ago (2015-01-16 00:05:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-16 00:52:05 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:53:25 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6740e67a815510b2a563dec1d7c9de256ad6d3ee
Cr-Commit-Position: refs/heads/master@{#311795}

Powered by Google App Engine
This is Rietveld 408576698