chrome/browser/chromeos/app_mode/kiosk_app_manager.h - Issue 827293003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/app_mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager.h

Issue 827293003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/app_mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_data.cc ('k') | chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/kiosk_app_manager.h

diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_manager.h b/chrome/browser/chromeos/app_mode/kiosk_app_manager.h

index a1006b822d11784dca416b106a2994b3ff0d46f3..d9a43fd7da9020619c607266f61777a8fd99bc9c 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_app_manager.h

+++ b/chrome/browser/chromeos/app_mode/kiosk_app_manager.h

@@ -217,7 +217,7 @@ class KioskAppManager : public KioskAppDataDelegate,

};

KioskAppManager();

- virtual ~KioskAppManager();

+ ~KioskAppManager() override;

// Stop all data loading and remove its dependency on CrosSettings.

void CleanUp();

@@ -230,15 +230,14 @@ class KioskAppManager : public KioskAppDataDelegate,

void UpdateAppData();

// KioskAppDataDelegate overrides:

- virtual void GetKioskAppIconCacheDir(base::FilePath* cache_dir) override;

- virtual void OnKioskAppDataChanged(const std::string& app_id) override;

- virtual void OnKioskAppDataLoadFailure(const std::string& app_id) override;

+ void GetKioskAppIconCacheDir(base::FilePath* cache_dir) override;

+ void OnKioskAppDataChanged(const std::string& app_id) override;

+ void OnKioskAppDataLoadFailure(const std::string& app_id) override;

// ExternalCache::Delegate:

- virtual void OnExtensionListsUpdated(

- const base::DictionaryValue* prefs) override;

- virtual void OnExtensionLoadedInCache(const std::string& id) override;

- virtual void OnExtensionDownloadFailed(

+ void OnExtensionListsUpdated(const base::DictionaryValue* prefs) override;

+ void OnExtensionLoadedInCache(const std::string& id) override;

+ void OnExtensionDownloadFailed(

const std::string& id,

extensions::ExtensionDownloaderDelegate::Error error) override;