Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 827093006: Fix WeakPtrFactory member in SSOAccessTokenFetcher (Closed)

Created:
5 years, 11 months ago by dmichael (off chromium)
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member in SSOAccessTokenFetcher This forces WeakPtrs to be invalidated before other members' destructors run. See the bug or the documentation of WeakPtrFactory for more information. I'm in the process of trying to turn on a clang check for this (see the bug). BUG=303818 R=rogerta@chromium.org Committed: https://crrev.com/19e69d46ae633294f50a3f59cc58fd142d60a370 Cr-Commit-Position: refs/heads/master@{#311408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/signin/ios/browser/profile_oauth2_token_service_ios.mm View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dmichael (off chromium)
5 years, 11 months ago (2015-01-13 23:45:29 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm For my own info, this rule about being last breaks if some class derives ...
5 years, 11 months ago (2015-01-14 01:34:51 UTC) #2
dmichael (off chromium)
On 2015/01/14 01:34:51, Roger Tawa wrote: > lgtm > > For my own info, this ...
5 years, 11 months ago (2015-01-14 03:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827093006/1
5 years, 11 months ago (2015-01-14 03:12:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 04:07:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 04:08:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19e69d46ae633294f50a3f59cc58fd142d60a370
Cr-Commit-Position: refs/heads/master@{#311408}

Powered by Google App Engine
This is Rietveld 408576698