Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: components/signin/ios/browser/profile_oauth2_token_service_ios.mm

Issue 827093006: Fix WeakPtrFactory member in SSOAccessTokenFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/ios/browser/profile_oauth2_token_service_ios.mm
diff --git a/components/signin/ios/browser/profile_oauth2_token_service_ios.mm b/components/signin/ios/browser/profile_oauth2_token_service_ios.mm
index cfa017d625ce22c804ed6b644adcc78cdab5c04a..aa9de2ac22859bf37c3919d1a76911a202c0e0d7 100644
--- a/components/signin/ios/browser/profile_oauth2_token_service_ios.mm
+++ b/components/signin/ios/browser/profile_oauth2_token_service_ios.mm
@@ -75,10 +75,10 @@ class SSOAccessTokenFetcher : public OAuth2AccessTokenFetcher {
NSError* error);
private:
- base::WeakPtrFactory<SSOAccessTokenFetcher> weak_factory_;
ios::ProfileOAuth2TokenServiceIOSProvider* provider_; // weak
std::string account_id_;
bool request_was_cancelled_;
+ base::WeakPtrFactory<SSOAccessTokenFetcher> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(SSOAccessTokenFetcher);
};
@@ -88,10 +88,10 @@ SSOAccessTokenFetcher::SSOAccessTokenFetcher(
ios::ProfileOAuth2TokenServiceIOSProvider* provider,
const std::string account_id)
: OAuth2AccessTokenFetcher(consumer),
- weak_factory_(this),
provider_(provider),
account_id_(account_id),
- request_was_cancelled_(false) {
+ request_was_cancelled_(false),
+ weak_factory_(this) {
DCHECK(provider_);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698