Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 827083004: Push API: handle both register and subscribe in browsertests. (Closed)

Created:
5 years, 11 months ago by Michael van Ouwerkerk
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: handle both register and subscribe in browsertests. BUG=446883 Committed: https://crrev.com/168f4d53d162e984853b1d16c8df1b55c8666de0 Cr-Commit-Position: refs/heads/master@{#310819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/test/data/push_messaging/push_test.js View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael van Ouwerkerk
Peter, could you take a look please?
5 years, 11 months ago (2015-01-09 17:14:17 UTC) #2
Michael van Ouwerkerk
Adding Miguel as he seemed interested in this rename.
5 years, 11 months ago (2015-01-09 17:14:37 UTC) #4
Peter Beverloo
lgtm Would be nice to have a TODO.
5 years, 11 months ago (2015-01-09 19:23:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827083004/1
5 years, 11 months ago (2015-01-09 19:25:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 19:36:08 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 19:37:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/168f4d53d162e984853b1d16c8df1b55c8666de0
Cr-Commit-Position: refs/heads/master@{#310819}

Powered by Google App Engine
This is Rietveld 408576698