IDL compiler: [CustomToV8] interface

Source/bindings/scripts/unstable/v8_interface.py

Index: Source/bindings/scripts/unstable/v8_interface.py
diff --git a/Source/bindings/scripts/unstable/v8_interface.py b/Source/bindings/scripts/unstable/v8_interface.py
index b6c29e543997628c2197e064e1c3db0a59719645..57823553262e812cb8962180c980df2497bc9efe 100644
--- a/Source/bindings/scripts/unstable/v8_interface.py
+++ b/Source/bindings/scripts/unstable/v8_interface.py
@@ -50,7 +50,6 @@ INTERFACE_H_INCLUDES = set([
 ])
 INTERFACE_CPP_INCLUDES = set([
     'RuntimeEnabledFeatures.h',
-    'bindings/v8/ScriptController.h',

[Nils Barth (inactive), 2013/11/22 06:10:48]

Now conditional; this makes a difference for 100+ generated files.
Code would be slightly simpler (2 lines) if this were always included, but
that's an extra header.

     'bindings/v8/V8Binding.h',
     'bindings/v8/V8DOMConfiguration.h',  # FIXME: necessary?
     'bindings/v8/V8DOMWrapper.h',  # FIXME: necessary?
@@ -67,6 +66,9 @@ def generate_interface(interface):
     extended_attributes = interface.extended_attributes
     v8_class_name = v8_utilities.v8_class_name(interface)
 
+    has_custom_to_v8 = 'CustomToV8' in extended_attributes  # [CustomToV8]
+    if not has_custom_to_v8:
+        includes.add('bindings/v8/ScriptController.h')

[haraken, 2013/11/22 07:14:04]

Why do we need ScriptController for [CustomToV8]?

[Nils Barth (inactive), 2013/12/03 02:52:28]

Actually this was included for all *but* [CustomToV8].
I looked into this, and it's only actually needed for interfaces
that inherit from Document.
I've fixed the Perl code to only include it there;
this removes one include!

     is_check_security = 'CheckSecurity' in extended_attributes
     if is_check_security:
         includes.update(['bindings/v8/BindingSecurity.h',
@@ -77,6 +79,7 @@ def generate_interface(interface):
         'conditional_string': conditional_string(interface),  # [Conditional]
         'cpp_class_name': cpp_name(interface),
         'has_custom_legacy_call': 'CustomLegacyCall' in extended_attributes,  # [CustomLegacyCall]
+        'has_custom_to_v8': has_custom_to_v8,
         'has_custom_wrap': 'CustomWrap' in extended_attributes,  # [CustomWrap]
         'has_resolve_wrapper_reachability': 'CustomIsReachable' in extended_attributes,  # [CustomIsReachable]
         'header_includes': INTERFACE_H_INCLUDES,