IDL compiler: [CustomToV8] interface

Source/bindings/scripts/unstable/v8_interface.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 32 matching lines @@
 from v8_utilities import conditional_string, cpp_name, runtime_enabled_function_name
 
 
 INTERFACE_H_INCLUDES = set([
     'bindings/v8/V8Binding.h',
     'bindings/v8/V8DOMWrapper.h',  # FIXME: necessary?
     'bindings/v8/WrapperTypeInfo.h',  # FIXME: necessary?
 ])
 INTERFACE_CPP_INCLUDES = set([
     'RuntimeEnabledFeatures.h',
-    'bindings/v8/ScriptController.h',

[Nils Barth (inactive), 2013/11/22 06:10:48]

Now conditional; this makes a difference for 100+ generated files.
Code would be slightly simpler (2 lines) if this were always included, but
that's an extra header.

     'bindings/v8/V8Binding.h',
     'bindings/v8/V8DOMConfiguration.h',  # FIXME: necessary?
     'bindings/v8/V8DOMWrapper.h',  # FIXME: necessary?
     'core/dom/ContextFeatures.h',
     'core/dom/Document.h',
     'platform/TraceEvent.h',
     'wtf/UnusedParam.h',
 ])
 
 
 def generate_interface(interface):
     includes.clear()
     includes.update(INTERFACE_CPP_INCLUDES)
     extended_attributes = interface.extended_attributes
     v8_class_name = v8_utilities.v8_class_name(interface)
 
+    has_custom_to_v8 = 'CustomToV8' in extended_attributes  # [CustomToV8]
+    if not has_custom_to_v8:
+        includes.add('bindings/v8/ScriptController.h')

[haraken, 2013/11/22 07:14:04]

Why do we need ScriptController for [CustomToV8]?

[Nils Barth (inactive), 2013/12/03 02:52:28]

Actually this was included for all *but* [CustomToV8].
I looked into this, and it's only actually needed for interfaces
that inherit from Document.
I've fixed the Perl code to only include it there;
this removes one include!

     is_check_security = 'CheckSecurity' in extended_attributes
     if is_check_security:
         includes.update(['bindings/v8/BindingSecurity.h',
                          'bindings/v8/ExceptionMessages.h',
                          'bindings/v8/ExceptionState.h'])
 
     template_contents = {
         'conditional_string': conditional_string(interface),  # [Conditional]
         'cpp_class_name': cpp_name(interface),
         'has_custom_legacy_call': 'CustomLegacyCall' in extended_attributes,  # [CustomLegacyCall]
+        'has_custom_to_v8': has_custom_to_v8,
         'has_custom_wrap': 'CustomWrap' in extended_attributes,  # [CustomWrap]
         'has_resolve_wrapper_reachability': 'CustomIsReachable' in extended_attributes,  # [CustomIsReachable]
         'header_includes': INTERFACE_H_INCLUDES,
         'interface_name': interface.name,
         'is_active_dom_object': 'ActiveDOMObject' in extended_attributes,  # [ActiveDOMObject]
         'is_check_security': is_check_security,
         'is_dependent_lifetime': 'DependentLifetime' in extended_attributes,  # [DependentLifetime]
         'v8_class_name': v8_class_name,
     }
 
@@ skipping 153 matching lines @@
                             '%s->IsString()' % cpp_value,
                             '%s->IsObject()' % cpp_value])
     if v8_types.array_or_sequence_type(idl_type):
         return '%s->IsArray()' % cpp_value
     if v8_types.is_wrapper_type(idl_type):
         type_check = 'V8{idl_type}::hasInstance({cpp_value}, info.GetIsolate(), worldType(info.GetIsolate()))'.format(idl_type=idl_type, cpp_value=cpp_value)
         if argument['is_nullable']:
             type_check = ' || '.join(['%s->IsNull()' % cpp_value, type_check])
         return type_check
     return None