Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/test/data/webui/net_internals/hsts_view.js

Issue 826423009: Treat HSTS and HPKP state independently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rsleevi comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | net/http/http_security_headers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/net_internals/hsts_view.js
diff --git a/chrome/test/data/webui/net_internals/hsts_view.js b/chrome/test/data/webui/net_internals/hsts_view.js
index cf7bdc3b12fe91efb736e49bd265a64147a43d8f..ac8c1965d4dd359aaca1262c437e68cd33a57636 100644
--- a/chrome/test/data/webui/net_internals/hsts_view.js
+++ b/chrome/test/data/webui/net_internals/hsts_view.js
@@ -169,7 +169,8 @@ CheckQueryResultTask.prototype = {
* case.
* @param {bool} pkpSubdomains Whether the pinning subdomain checkbox should be
* selected. Also the corresponding expected return value, in the success
- * case.
+ * case. When publicKeyHashes is INVALID_HASH, the expected return value
+ * is false.
* @param {number} stsObserved The time the STS policy was observed.
* @param {number} pkpObserved The time the PKP policy was observed.
* @param {string} publicKeyHashes Public key hash to send. Also the
@@ -181,8 +182,11 @@ CheckQueryResultTask.prototype = {
function AddTask(domain, stsSubdomains, pkpSubdomains, publicKeyHashes,
stsObserved, pkpObserved, queryResultType) {
this.requestedPublicKeyHashes_ = publicKeyHashes;
- if (publicKeyHashes == INVALID_HASH)
+ this.requestedPkpSubdomains_ = pkpSubdomains;
+ if (publicKeyHashes == INVALID_HASH) {
+ pkpSubdomains = false;
publicKeyHashes = '';
+ }
CheckQueryResultTask.call(this, domain, stsSubdomains, pkpSubdomains,
stsObserved, pkpObserved, publicKeyHashes,
queryResultType);
@@ -198,7 +202,7 @@ AddTask.prototype = {
start: function() {
$(HSTSView.ADD_INPUT_ID).value = this.domain_;
$(HSTSView.ADD_STS_CHECK_ID).checked = this.stsSubdomains_;
- $(HSTSView.ADD_PKP_CHECK_ID).checked = this.pkpSubdomains_;
+ $(HSTSView.ADD_PKP_CHECK_ID).checked = this.requestedPkpSubdomains_;
$(HSTSView.ADD_PINS_ID).value = this.requestedPublicKeyHashes_;
$(HSTSView.ADD_SUBMIT_ID).click();
CheckQueryResultTask.prototype.start.call(this);
@@ -383,13 +387,13 @@ TEST_F('NetInternalsTest', 'netInternalsHSTSViewAddTwice', function() {
now, now, QueryResultType.SUCCESS));
taskQueue.addTask(new QueryTask('somewhereelse.com', false, false, now, now,
'', QueryResultType.NOT_FOUND));
- taskQueue.addTask(new AddTask('somewhereelse.com', true, true, '',
+ taskQueue.addTask(new AddTask('somewhereelse.com', true, false, '',
now, now, QueryResultType.SUCCESS));
taskQueue.addTask(new QueryTask('somewhere.com', false, false, now, now,
VALID_HASH, QueryResultType.SUCCESS));
taskQueue.addTask(new DeleteTask('somewhere.com', QueryResultType.NOT_FOUND));
- taskQueue.addTask(new QueryTask('somewhereelse.com', true, true, now, now, '',
- QueryResultType.SUCCESS));
+ taskQueue.addTask(new QueryTask('somewhereelse.com', true, false, now, now,
+ '', QueryResultType.SUCCESS));
taskQueue.addTask(new DeleteTask('somewhereelse.com',
QueryResultType.NOT_FOUND));
taskQueue.run(true);
« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | net/http/http_security_headers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698