Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 826423009: Treat HSTS and HPKP state independently. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rsleevi comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc
diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
index d0379094849eed40c00c3bdea8c8892504d1e5ca..93022ab164d1b9c95e7c114f2f03fbf74bf6b42c 100644
--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
@@ -818,6 +818,8 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSQuery(
static_state.pkp.expiry.ToDoubleT());
result->SetString("static_spki_hashes",
HashesToBase64String(static_state.pkp.spki_hashes));
+ result->SetString("static_sts_domain", static_state.sts.domain);
+ result->SetString("static_pkp_domain", static_state.pkp.domain);
}
net::TransportSecurityState::DomainState dynamic_state;
@@ -841,16 +843,11 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSQuery(
dynamic_state.pkp.expiry.ToDoubleT());
result->SetString("dynamic_spki_hashes",
HashesToBase64String(dynamic_state.pkp.spki_hashes));
+ result->SetString("dynamic_sts_domain", dynamic_state.sts.domain);
+ result->SetString("dynamic_pkp_domain", dynamic_state.pkp.domain);
}
result->SetBoolean("result", found_static || found_dynamic);
- if (found_static) {
- result->SetString("domain", static_state.domain);
- } else if (found_dynamic) {
- result->SetString("domain", dynamic_state.domain);
- } else {
- result->SetString("domain", domain);
- }
}
}
« no previous file with comments | « chrome/browser/resources/net_internals/hsts_view.js ('k') | chrome/test/data/webui/net_internals/hsts_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698