Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: mojo/services/surfaces/public/interfaces/surfaces.mojom

Issue 826423008: Use local ids for Surfaces APIs that can only apply to local surfaces (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/surfaces/public/interfaces/surfaces.mojom
diff --git a/mojo/services/surfaces/public/interfaces/surfaces.mojom b/mojo/services/surfaces/public/interfaces/surfaces.mojom
index caaddedef6784aeedfa68f6927089263a55b565d..9fc65e8c8d95e3bd66f2efe0fc14bcbef207757c 100644
--- a/mojo/services/surfaces/public/interfaces/surfaces.mojom
+++ b/mojo/services/surfaces/public/interfaces/surfaces.mojom
@@ -61,19 +61,17 @@ interface SurfaceClient {
[Client=SurfaceClient]
interface Surface {
- // The id's local field is allocated by the caller and must be unique. The
- // id_namespace field on the id may be 0 or this connection's namespace.
- CreateSurface(SurfaceId id);
+ CreateSurface(uint32 id_local);
// The client can only submit frames to surfaces created with this
// connection. After the submitted frame is drawn for the first time, the
// surface will respond to the SubmitFrame message. Clients should use this
// acknowledgement to ratelimit frame submissions.
- SubmitFrame(SurfaceId id, Frame frame) => ();
- DestroySurface(SurfaceId id);
+ SubmitFrame(uint32 id_local, Frame frame) => ();
+ DestroySurface(uint32 id_local);
CreateGLES2BoundSurface(CommandBuffer gles2_client,
- SurfaceId id,
+ uint32 id_local,
Size size,
ViewportParameterListener& listener);
};

Powered by Google App Engine
This is Rietveld 408576698