Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: LayoutTests/fast/canvas/webgl/webgl-error-response.html

Issue 826363002: Webgl Info should have vendorid and deviceid of gpu. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code rework. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/webgl/webgl-error-response.html
diff --git a/LayoutTests/fast/canvas/webgl/webgl-error-response.html b/LayoutTests/fast/canvas/webgl/webgl-error-response.html
index 79410177a2839e113a8a457263139f4fc74feb07..9e87f03007e1695eb6b36497440b5e7952679bda 100644
--- a/LayoutTests/fast/canvas/webgl/webgl-error-response.html
+++ b/LayoutTests/fast/canvas/webgl/webgl-error-response.html
@@ -21,19 +21,17 @@ function initTest() {
}
function onContextCreationError(e) {
- var vendorInfoStr = "VendorInfo = ";
- var renderInfoStr = "RendererInfo = ";
- var driverInfoStr = "DriverInfo = ";
- var stringIndex = e.statusMessage.search(vendorInfoStr) + vendorInfoStr.length;
- var vendorInfo = e.statusMessage.substring(stringIndex, e.statusMessage.search(renderInfoStr) - 2);
- stringIndex = e.statusMessage.search(renderInfoStr) + renderInfoStr.length;
- var rendererInfo = e.statusMessage.substring(stringIndex, e.statusMessage.search(driverInfoStr) - 2 );
- stringIndex = e.statusMessage.search(driverInfoStr) + driverInfoStr.length;
- var driverInfo = e.statusMessage.substring(stringIndex, e.statusMessage.length - 1);
- if((e.statusMessage.search("GPUInfoCollectionFailure") != -1) ||
- vendorInfo.length > 0 ||
- rendererInfo.length > 0 ||
- driverInfo.length > 0)
+ var splitStatus = e.statusMessage.split(",");
+ var stringLocator = 1;
+ var status = true;
+ for (var i = 0; i < splitStatus.length; i++) {
+ var gpuInfoStr = splitStatus[i].split(" = ");
+ if (gpuInfoStr[stringLocator].length > 0)
Ken Russell (switch to Gerrit) 2015/02/13 17:32:58 Looking at this again I'm not sure it does what yo
sivag 2015/02/16 15:00:18 Done.
+ status = true;
+ else
+ status = false;
+ }
+ if(status)
testPassed("Status message displayed for webglcontextcreationerror");
else
testFailed("Context creation error test failed");

Powered by Google App Engine
This is Rietveld 408576698