Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.cpp

Issue 826363002: Webgl Info should have vendorid and deviceid of gpu. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code rework. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLRenderingContextBase.cpp
diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.cpp b/Source/core/html/canvas/WebGLRenderingContextBase.cpp
index 46909bd6b222a9c227fd47110fb23eff5dbb762c..40ae94a11f21fbde0d01a26e46a384033b7d990d 100644
--- a/Source/core/html/canvas/WebGLRenderingContextBase.cpp
+++ b/Source/core/html/canvas/WebGLRenderingContextBase.cpp
@@ -602,15 +602,17 @@ PassOwnPtr<blink::WebGraphicsContext3D> WebGLRenderingContextBase::createWebGrap
shouldFailContextCreationForTesting = false;
String statusMessage;
if (!glInfo.contextInfoCollectionFailure.isEmpty()) {
- statusMessage.append("Could not create a WebGL context.");
+ statusMessage.append("Could not create a WebGL context. ");
statusMessage.append(glInfo.contextInfoCollectionFailure);
+ statusMessage.append("VendorId = " + String::number(glInfo.vendorId));
+ statusMessage.append(", DriverId = " + String::number(glInfo.deviceId));
Ken Russell (switch to Gerrit) 2015/02/13 17:32:58 DeviceId, not DriverId
sivag 2015/02/16 15:00:18 Done.
} else {
statusMessage.append("Could not create a WebGL context");
if (!glInfo.vendorInfo.isEmpty()) {
- statusMessage.append(" VendorInfo = ");
+ statusMessage.append(", VendorInfo = ");
statusMessage.append(glInfo.vendorInfo);
} else {
- statusMessage.append(" VendorInfo = Not Available");
+ statusMessage.append(", VendorInfo = Not Available");
}
if (!glInfo.rendererInfo.isEmpty()) {
statusMessage.append(", RendererInfo = ");

Powered by Google App Engine
This is Rietveld 408576698