Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: content/browser/accessibility/dump_accessibility_events_browsertest.cc

Issue 826323002: Add proper path separator(\) for testing AX test cases on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/dump_accessibility_events_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_events_browsertest.cc b/content/browser/accessibility/dump_accessibility_events_browsertest.cc
index 25f2dab8f696d7b43fef37714b31d511522d4bb1..fee68cb0557b04dfba34c233d206668af774f3ab 100644
--- a/content/browser/accessibility/dump_accessibility_events_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_events_browsertest.cc
@@ -138,13 +138,16 @@ void DumpAccessibilityEventsTest::RunEventTest(
const base::FilePath::CharType* file_path) {
base::FilePath dir_test_data;
ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &dir_test_data));
- base::FilePath test_path(
- dir_test_data.AppendASCII("accessibility/event"));
- ASSERT_TRUE(base::PathExists(test_path))
- << test_path.LossyDisplayName();
+
+ const char* file_dir = "accessibility/event";
dmazzoni 2015/01/05 09:04:59 Use the FilePath class (base/files/file_path.h) to
+#if defined(OS_WIN)
+ file_dir = "accessibility\\event";
+#endif
+ base::FilePath test_path(dir_test_data.AppendASCII(file_dir));
+ ASSERT_TRUE(base::PathExists(test_path)) << test_path.LossyDisplayName();
base::FilePath event_file = test_path.Append(base::FilePath(file_path));
dmazzoni 2015/01/05 09:04:59 It might be easiest to rewrite the code to append
- RunTest(event_file, "accessibility/event");
+ RunTest(event_file, file_dir);
}
// TODO(dmazzoni): port these tests to run on all platforms.
« no previous file with comments | « no previous file | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698