Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 826323002: Add proper path separator(\) for testing AX test cases on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index 94758dd240221363e47b1990fe2e34e774a952f3..696b65953bb3a7d4a58aee9b651b07db93d2e90e 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -66,25 +66,31 @@ class DumpAccessibilityTreeTest : public DumpAccessibilityTestBase {
void RunAriaTest(const base::FilePath::CharType* file_path) {
base::FilePath dir_test_data;
ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &dir_test_data));
- base::FilePath test_path(
- dir_test_data.AppendASCII("accessibility/aria"));
- ASSERT_TRUE(base::PathExists(test_path))
- << test_path.LossyDisplayName();
+
+ const char* file_dir = "accessibility/aria";
+ #if defined(OS_WIN)
+ file_dir = "accessibility\\aria";
+ #endif
+ base::FilePath test_path(dir_test_data.AppendASCII(file_dir));
+ ASSERT_TRUE(base::PathExists(test_path)) << test_path.LossyDisplayName();
base::FilePath aria_file = test_path.Append(base::FilePath(file_path));
- RunTest(aria_file, "accessibility/aria");
+ RunTest(aria_file, file_dir);
}
void RunHtmlTest(const base::FilePath::CharType* file_path) {
base::FilePath dir_test_data;
ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &dir_test_data));
- base::FilePath test_path(
- dir_test_data.AppendASCII("accessibility/html"));
- ASSERT_TRUE(base::PathExists(test_path))
- << test_path.LossyDisplayName();
+
+ const char* file_dir = "accessibility/html";
+ #if defined(OS_WIN)
+ file_dir = "accessibility\\html";
+ #endif
+ base::FilePath test_path(dir_test_data.AppendASCII(file_dir));
+ ASSERT_TRUE(base::PathExists(test_path)) << test_path.LossyDisplayName();
base::FilePath html_file = test_path.Append(base::FilePath(file_path));
- RunTest(html_file, "accessibility/html");
+ RunTest(html_file, file_dir);
}
std::vector<std::string> Dump() override {

Powered by Google App Engine
This is Rietveld 408576698