Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 826283002: Add support for sending a USB SET_CONFIGURATION request. (Closed)

Created:
5 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for sending a USB SET_CONFIGURATION request. Some devices may have multiple configuration options, and Windows and OS X do not always automatically select a device configuration when a device is enumerated. This new function allows a Chrome App to select a device configuration once the device is opened. From a security and isolation perspective this function is no more dangerous than chrome.usb.resetDevice. BUG=443213 Committed: https://crrev.com/13cf2cfcb5325ecfff98ee8ccde723f22e606d22 Cr-Commit-Position: refs/heads/master@{#310591}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -321 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.cc View 3 chunks +29 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/device_permissions_manager_unittest.cc View 1 2 6 chunks +97 lines, -96 lines 0 comments Download
M device/usb/usb_device.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M device/usb/usb_device_filter.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M device/usb/usb_device_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/usb_device_handle_impl.h View 3 chunks +2 lines, -4 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 4 chunks +37 lines, -18 lines 0 comments Download
M device/usb/usb_device_impl.h View 3 chunks +9 lines, -6 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 4 chunks +69 lines, -79 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 1 2 7 chunks +57 lines, -19 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 7 chunks +45 lines, -44 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/api/usb.idl View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M extensions/test/data/api_test/usb/list_interfaces/test.js View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/test/data/api_test/usb/reset_device/test.js View 1 chunk +3 lines, -4 lines 0 comments Download
A + extensions/test/data/api_test/usb/set_configuration/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
A extensions/test/data/api_test/usb/set_configuration/test.js View 1 chunk +26 lines, -0 lines 0 comments Download
M extensions/test/data/api_test/usb/transfer_failure/test.js View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Reilly Grant (use Gerrit)
rockot@, please take a look at this new API and the device code behind it. ...
5 years, 11 months ago (2014-12-30 22:13:21 UTC) #7
jar (doing other things)
Singular addition to histograms.xml LGTM... but I haven't looked at any of the other code.
5 years, 11 months ago (2014-12-30 22:31:27 UTC) #9
Reilly Grant (use Gerrit)
Adding Mustafa for security review.
5 years, 11 months ago (2015-01-05 18:17:24 UTC) #11
dgozman
devtools lgtm btw, do you plan on making GetConfiguration call work on windows with already ...
5 years, 11 months ago (2015-01-06 10:17:28 UTC) #13
Reilly Grant (use Gerrit)
On 2015/01/06 10:17:28, dgozman wrote: > devtools lgtm > > btw, do you plan on ...
5 years, 11 months ago (2015-01-06 19:14:31 UTC) #14
Ken Rockot(use gerrit already)
lgtm
5 years, 11 months ago (2015-01-06 23:51:37 UTC) #15
meacer
Lgtm
5 years, 11 months ago (2015-01-08 14:47:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826283002/120001
5 years, 11 months ago (2015-01-08 16:05:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_rel/builds/3938) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34047)
5 years, 11 months ago (2015-01-08 16:12:43 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826283002/140001
5 years, 11 months ago (2015-01-08 19:09:35 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:140001)
5 years, 11 months ago (2015-01-08 20:47:20 UTC) #24
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 20:48:53 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/13cf2cfcb5325ecfff98ee8ccde723f22e606d22
Cr-Commit-Position: refs/heads/master@{#310591}

Powered by Google App Engine
This is Rietveld 408576698